Codecov Report

Merging #964 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #964   +/-   ##
=======================================
  Coverage   88.33%   88.33%           
=======================================
  Files          29       29           
  Lines         797      797           
=======================================
  Hits          704      704           
  Misses         93       93           

Adding a couple of notes here: The example above was using nested data, which obviously goes against the recommendation of the docs. The good news is this typing approach is still valid when flattened. So - we'd be covered in the event folks have bad schemas (like me!) or follow the docs.

export const selectFirestoreTasks = (state: RootState, subdomain: string) =>
  state.firestore.ordered.tasks || [];

interface FirestoreSchema {
  tasks: FirestoreReducer.Entity<FirestoreTask>;
}

It was also recommended to do something like this on firestoreReducer so that TS users can have it typed easily:

combineReducers({ firestore: firestoreReducer.forSchema<Schema>() })

My only other thought regarding the reducer is that if we're passing in a schema, we should also use it to initialize the firestore reducer state to get rid of the extra initializer like in the selectFirestoreTasks selector above.

Closing this out and will open against the typescript branch of redux-firestore if desired.